Mark completed TODO

This commit is contained in:
Manav Rathi 2024-05-13 20:16:39 +05:30
parent bf7c97c006
commit 859adea2eb
No known key found for this signature in database
2 changed files with 0 additions and 6 deletions

View file

@ -46,11 +46,6 @@ export const ffmpegExec = async (
dataOrPathOrZipItem: Uint8Array | string | ZipItem,
outputFileExtension: string,
): Promise<Uint8Array> => {
// TODO (MR): This currently copies files for both input (when
// dataOrPathOrZipItem is data) and output. This needs to be tested
// extremely large video files when invoked downstream of `convertToMP4` in
// the web code.
const {
path: inputFilePath,
isFileTemporary: isInputFileTemporary,

View file

@ -576,7 +576,6 @@ async function getPlayableVideo(
if (!forceConvert && !runOnWeb && !isElectron()) {
return null;
}
// TODO(MR): This might not work for very large (~ GB) videos. Test.
log.info(`Converting video ${videoNameTitle} to mp4`);
const convertedVideoData = await ffmpeg.convertToMP4(videoBlob);
return new Blob([convertedVideoData], { type: "video/mp4" });