Mark completed TODO
This commit is contained in:
parent
bf7c97c006
commit
859adea2eb
|
@ -46,11 +46,6 @@ export const ffmpegExec = async (
|
||||||
dataOrPathOrZipItem: Uint8Array | string | ZipItem,
|
dataOrPathOrZipItem: Uint8Array | string | ZipItem,
|
||||||
outputFileExtension: string,
|
outputFileExtension: string,
|
||||||
): Promise<Uint8Array> => {
|
): Promise<Uint8Array> => {
|
||||||
// TODO (MR): This currently copies files for both input (when
|
|
||||||
// dataOrPathOrZipItem is data) and output. This needs to be tested
|
|
||||||
// extremely large video files when invoked downstream of `convertToMP4` in
|
|
||||||
// the web code.
|
|
||||||
|
|
||||||
const {
|
const {
|
||||||
path: inputFilePath,
|
path: inputFilePath,
|
||||||
isFileTemporary: isInputFileTemporary,
|
isFileTemporary: isInputFileTemporary,
|
||||||
|
|
|
@ -576,7 +576,6 @@ async function getPlayableVideo(
|
||||||
if (!forceConvert && !runOnWeb && !isElectron()) {
|
if (!forceConvert && !runOnWeb && !isElectron()) {
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
// TODO(MR): This might not work for very large (~ GB) videos. Test.
|
|
||||||
log.info(`Converting video ${videoNameTitle} to mp4`);
|
log.info(`Converting video ${videoNameTitle} to mp4`);
|
||||||
const convertedVideoData = await ffmpeg.convertToMP4(videoBlob);
|
const convertedVideoData = await ffmpeg.convertToMP4(videoBlob);
|
||||||
return new Blob([convertedVideoData], { type: "video/mp4" });
|
return new Blob([convertedVideoData], { type: "video/mp4" });
|
||||||
|
|
Loading…
Reference in a new issue