beenull/ente
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

no need to pass complete files list to getThumbnail

Browse source
This commit is contained in:
Abhinav 2023-02-04 12:37:42 +05:30
parent 8758671a9b
commit 806abcd7be
2 changed files with 25 additions and 35 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

56
src/components/PhotoFrame.tsx
View file

@ -546,41 +546,31 @@ const PhotoFrame = ({
}
};
const getThumbnail = (
files: EnteFile[],
item: EnteFile,
index: number,
isScrolling: boolean
) =>
files[index] ? (
<PreviewCard
key={`tile-${files[index].id}-selected-${
selected[files[index].id] ?? false
}`}
file={files[index]}
updateURL={updateURL(index)}
onClick={onThumbnailClick(index)}
onSelect={handleSelect(
files[index].id,
files[index].ownerID === user.id,
index
)}
selected={
selected.collectionID === activeCollection &&
selected[files[index].id]
}
selectOnClick={selected.count > 0}
onHover={onHoverOver(index)}
onRangeSelect={handleRangeSelect(index)}
isRangeSelectActive={isShiftKeyPressed && selected.count > 0}
isInsSelectRange={
(index >= rangeStart && index <= currentHover) ||
(index >= currentHover && index <= rangeStart)
}
activeCollection={activeCollection}
showPlaceholder={isScrolling}
/>
) : (
<></>
);
) => (
<PreviewCard
key={`tile-${item.id}-selected-${selected[item.id] ?? false}`}
file={item}
updateURL={updateURL(index)}
onClick={onThumbnailClick(index)}
onSelect={handleSelect(item.id, item.ownerID === user.id, index)}
selected={
selected.collectionID === activeCollection && selected[item.id]
}
selectOnClick={selected.count > 0}
onHover={onHoverOver(index)}
onRangeSelect={handleRangeSelect(index)}
isRangeSelectActive={isShiftKeyPressed && selected.count > 0}
isInsSelectRange={
(index >= rangeStart && index <= currentHover) ||
(index >= currentHover && index <= rangeStart)
}
activeCollection={activeCollection}
showPlaceholder={isScrolling}
/>
);
const getSlideData = async (
instance: PhotoSwipe<PhotoSwipe.Options>,

4
src/components/PhotoList.tsx
View file

@ -163,7 +163,7 @@ interface Props {
filteredData: EnteFile[];
showAppDownloadBanner: boolean;
getThumbnail: (
files: EnteFile[],
file: EnteFile,
index: number,
isScrolling?: boolean
) => JSX.Element;
@ -654,7 +654,7 @@ export function PhotoList({
case ITEM_TYPE.FILE: {
const ret = listItem.items.map((item, idx) =>
getThumbnail(
filteredData,
item,
listItem.itemStartIndex + idx,
isScrolling
)