no need to pass complete files list to getThumbnail

This commit is contained in:
Abhinav 2023-02-04 12:37:42 +05:30
parent 8758671a9b
commit 806abcd7be
2 changed files with 25 additions and 35 deletions

View file

@ -546,26 +546,18 @@ const PhotoFrame = ({
} }
}; };
const getThumbnail = ( const getThumbnail = (
files: EnteFile[], item: EnteFile,
index: number, index: number,
isScrolling: boolean isScrolling: boolean
) => ) => (
files[index] ? (
<PreviewCard <PreviewCard
key={`tile-${files[index].id}-selected-${ key={`tile-${item.id}-selected-${selected[item.id] ?? false}`}
selected[files[index].id] ?? false file={item}
}`}
file={files[index]}
updateURL={updateURL(index)} updateURL={updateURL(index)}
onClick={onThumbnailClick(index)} onClick={onThumbnailClick(index)}
onSelect={handleSelect( onSelect={handleSelect(item.id, item.ownerID === user.id, index)}
files[index].id,
files[index].ownerID === user.id,
index
)}
selected={ selected={
selected.collectionID === activeCollection && selected.collectionID === activeCollection && selected[item.id]
selected[files[index].id]
} }
selectOnClick={selected.count > 0} selectOnClick={selected.count > 0}
onHover={onHoverOver(index)} onHover={onHoverOver(index)}
@ -578,8 +570,6 @@ const PhotoFrame = ({
activeCollection={activeCollection} activeCollection={activeCollection}
showPlaceholder={isScrolling} showPlaceholder={isScrolling}
/> />
) : (
<></>
); );
const getSlideData = async ( const getSlideData = async (

View file

@ -163,7 +163,7 @@ interface Props {
filteredData: EnteFile[]; filteredData: EnteFile[];
showAppDownloadBanner: boolean; showAppDownloadBanner: boolean;
getThumbnail: ( getThumbnail: (
files: EnteFile[], file: EnteFile,
index: number, index: number,
isScrolling?: boolean isScrolling?: boolean
) => JSX.Element; ) => JSX.Element;
@ -654,7 +654,7 @@ export function PhotoList({
case ITEM_TYPE.FILE: { case ITEM_TYPE.FILE: {
const ret = listItem.items.map((item, idx) => const ret = listItem.items.map((item, idx) =>
getThumbnail( getThumbnail(
filteredData, item,
listItem.itemStartIndex + idx, listItem.itemStartIndex + idx,
isScrolling isScrolling
) )