beenull/ente
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Remove l11n unsafe direct string manipulation

Browse source
This commit is contained in:
Manav Rathi 2024-04-07 10:23:20 +05:30
parent 01e6e79819
commit 7c0ab6dd8a
No known key found for this signature in database
3 changed files with 3 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
web/apps/photos/src/components/pages/gallery/PlanSelector/card/index.tsx
View file

@ -24,7 +24,6 @@ import {
planForSubscription,
updateSubscription,
} from "utils/billing";
import { reverseString } from "utils/common";
import { getLocalUserDetails } from "utils/user";
import { getTotalFamilyUsage, isPartOfFamily } from "utils/user/family";
import FreeSubscriptionPlanSelectorCard from "./free";
@ -130,9 +129,7 @@ function PlanSelectorCard(props: Props) {
}
} else if (hasStripeSubscription(subscription)) {
appContext.setDialogMessage({
title: `${t("CONFIRM")} ${reverseString(
t("UPDATE_SUBSCRIPTION"),
)}`,
title: t("update_subscription_title"),
content: t("UPDATE_SUBSCRIPTION_MESSAGE"),
proceed: {
text: t("UPDATE_SUBSCRIPTION"),

7
web/apps/photos/src/utils/common/index.ts
View file

@ -13,12 +13,6 @@ export function downloadApp() {
openLink(APP_DOWNLOAD_URL, true);
}
export function reverseString(title: string) {
return title
?.split(" ")
.reduce((reversedString, currWord) => `${currWord} ${reversedString}`);
}
export function initiateEmail(email: string) {
const a = document.createElement("a");
a.href = "mailto:" + email;
@ -33,6 +27,7 @@ export const preloadImage = (imgBasePath: string) => {
}
new Image().srcset = srcSet.join(",");
};
export function openLink(href: string, newTab?: boolean) {
const a = document.createElement("a");
a.href = href;

1
web/packages/next/locales/en-US/translation.json
View file

@ -168,6 +168,7 @@
"UPDATE_PAYMENT_METHOD": "Update payment method",
"MONTHLY": "Monthly",
"YEARLY": "Yearly",
"update_subscription_title": "Confirm plan change",
"UPDATE_SUBSCRIPTION_MESSAGE": "Are you sure you want to change your plan?",
"UPDATE_SUBSCRIPTION": "Change plan",
"CANCEL_SUBSCRIPTION": "Cancel subscription",