beenull/ente
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Auth: Fix bug in filtering out null values

Browse source
This commit is contained in:
Neeraj Gupta 2023-08-10 14:49:28 +05:30
parent e3dbdfc533
commit 7599080722
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
apps/photos/src/services/authenticator/authenticatorService.ts
View file

@ -40,10 +40,12 @@ export const getAuthCodes = async (): Promise<Code[]> => {
return null;
}
})
.filter((f) => f !== null || f !== undefined)
);
// sort by issuer name which can be undefined also
authCodes.sort((a, b) => {
// Remove null and undefined values
const filteredAuthCodes = authCodes.filter(
(f) => f !== null && f !== undefined
);
filteredAuthCodes.sort((a, b) => {
if (a.issuer && b.issuer) {
return a.issuer.localeCompare(b.issuer);
}
@ -55,7 +57,7 @@ export const getAuthCodes = async (): Promise<Code[]> => {
}
return 0;
});
return authCodes;
return filteredAuthCodes;
} catch (e) {
if (e.message !== CustomError.AUTH_KEY_NOT_FOUND) {
logError(e, 'get authenticator entities failed');