From 74360f3c844163cf93d3c6501d4ed49770a14224 Mon Sep 17 00:00:00 2001
From: Neeraj Gupta <254676+ua741@users.noreply.github.com>
Date: Mon, 22 Apr 2024 09:41:14 +0530
Subject: [PATCH] [server] Fix validation for fileUpdate

---
 server/pkg/controller/file.go | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/server/pkg/controller/file.go b/server/pkg/controller/file.go
index a4ac4b1b7..02d2cad64 100644
--- a/server/pkg/controller/file.go
+++ b/server/pkg/controller/file.go
@@ -64,8 +64,11 @@ func (c *FileController) validateFileCreateOrUpdateReq(userID int64, file ente.F
 	if !strings.HasPrefix(file.File.ObjectKey, objectPathPrefix) || !strings.HasPrefix(file.Thumbnail.ObjectKey, objectPathPrefix) {
 		return stacktrace.Propagate(ente.ErrBadRequest, "Incorrect object key reported")
 	}
-	if file.EncryptedKey == "" || file.KeyDecryptionNonce == "" {
-		return stacktrace.Propagate(ente.ErrBadRequest, "EncryptedKey and KeyDecryptionNonce are required")
+	// Check for attributes for fileCreation. We don't send key details on update
+	if file.ID == 0 {
+		if file.EncryptedKey == "" || file.KeyDecryptionNonce == "" {
+			return stacktrace.Propagate(ente.ErrBadRequest, "EncryptedKey and KeyDecryptionNonce are required")
+		}
 	}
 	if file.File.DecryptionHeader == "" || file.Thumbnail.DecryptionHeader == "" {
 		return stacktrace.Propagate(ente.ErrBadRequest, "DecryptionHeader for file & thumb is required")