Remove unncessary awaits by passing pref

This commit is contained in:
Neeraj Gupta 2022-11-06 11:44:46 +05:30
parent 01121ddc62
commit 709e2a0085
No known key found for this signature in database
GPG key ID: 3C5A1684DC1729E1
11 changed files with 34 additions and 33 deletions

View file

@ -123,8 +123,9 @@ void _headlessTaskHandler(HeadlessTask task) {
Future<void> _init(bool isBackground, {String via = ''}) async {
_isProcessRunning = true;
_logger.info("Initializing... inBG =$isBackground via: $via");
final SharedPreferences preferences = await SharedPreferences.getInstance();
await _logFGHeartBeatInfo();
_scheduleHeartBeat(isBackground);
_scheduleHeartBeat(preferences, isBackground);
if (isBackground) {
AppLifecycleService.instance.onAppInBackground('init via: $via');
} else {
@ -137,17 +138,17 @@ Future<void> _init(bool isBackground, {String via = ''}) async {
await UserService.instance.init();
await UserRemoteFlagService.instance.init();
await UpdateService.instance.init();
await BillingService.instance.init();
await CollectionsService.instance.init();
await FileUploader.instance.init(isBackground);
await LocalSyncService.instance.init();
await TrashSyncService.instance.init();
await RemoteSyncService.instance.init();
await SyncService.instance.init();
await MemoriesService.instance.init();
await LocalSettings.instance.init();
await LocalFileUpdateService.instance.init();
await SearchService.instance.init();
BillingService.instance.init();
await CollectionsService.instance.init(preferences);
await FileUploader.instance.init(preferences, isBackground);
await LocalSyncService.instance.init(preferences);
TrashSyncService.instance.init(preferences);
RemoteSyncService.instance.init(preferences);
await SyncService.instance.init(preferences);
MemoriesService.instance.init();
LocalSettings.instance.init(preferences);
LocalFileUpdateService.instance.init(preferences);
SearchService.instance.init();
if (Platform.isIOS) {
PushService.instance.init().then((_) {
FirebaseMessaging.onBackgroundMessage(
@ -186,14 +187,14 @@ Future _runWithLogs(Function() function, {String prefix = ""}) async {
);
}
Future<void> _scheduleHeartBeat(bool isBackground) async {
final prefs = await SharedPreferences.getInstance();
Future<void> _scheduleHeartBeat(
SharedPreferences prefs, bool isBackground) async {
await prefs.setInt(
isBackground ? kLastBGTaskHeartBeatTime : kLastFGTaskHeartBeatTime,
DateTime.now().microsecondsSinceEpoch,
);
Future.delayed(kHeartBeatFrequency, () async {
_scheduleHeartBeat(isBackground);
_scheduleHeartBeat(prefs, isBackground);
});
}

View file

@ -62,8 +62,8 @@ class CollectionsService {
static final CollectionsService instance =
CollectionsService._privateConstructor();
Future<void> init() async {
_prefs = await SharedPreferences.getInstance();
Future<void> init(SharedPreferences preferences) async {
_prefs = preferences;
final collections = await _db.getAllCollections();
for (final collection in collections) {

View file

@ -28,8 +28,8 @@ class LocalFileUpdateService {
_fileUpdationDB = FileUpdationDB.instance;
}
Future<void> init() async {
_prefs = await SharedPreferences.getInstance();
void init(SharedPreferences preferences) async {
_prefs = preferences;
}
static LocalFileUpdateService instance =

View file

@ -47,8 +47,8 @@ class LocalSyncService {
static final LocalSyncService instance =
LocalSyncService._privateConstructor();
Future<void> init() async {
_prefs = await SharedPreferences.getInstance();
Future<void> init(SharedPreferences preferences) async {
_prefs = preferences;
if (!AppLifecycleService.instance.isForeground) {
await PhotoManager.setIgnorePermissionCheck(true);
}

View file

@ -25,7 +25,7 @@ class MemoriesService extends ChangeNotifier {
static final MemoriesService instance = MemoriesService._privateConstructor();
Future<void> init() async {
void init() {
addListener(() {
_cachedMemories = null;
});

View file

@ -65,8 +65,8 @@ class RemoteSyncService {
RemoteSyncService._privateConstructor();
Future<void> init() async {
_prefs = await SharedPreferences.getInstance();
void init(SharedPreferences preferences) {
_prefs = preferences;
Bus.instance.on<LocalPhotosUpdatedEvent>().listen((event) async {
if (event.type == EventType.addedOrUpdated) {

View file

@ -32,7 +32,7 @@ class SearchService {
static final SearchService instance = SearchService._privateConstructor();
Future<void> init() async {
void init() {
Bus.instance.on<LocalPhotosUpdatedEvent>().listen((event) {
// only invalidate, let the load happen on demand
_cachedFilesFuture = null;

View file

@ -60,8 +60,8 @@ class SyncService {
static final SyncService instance = SyncService._privateConstructor();
Future<void> init() async {
_prefs = await SharedPreferences.getInstance();
Future<void> init(SharedPreferences preferences) async {
_prefs = preferences;
if (Platform.isIOS) {
_logger.info("Clearing file cache");
await PhotoManager.clearFileCache();

View file

@ -32,8 +32,8 @@ class TrashSyncService {
TrashSyncService._privateConstructor();
final _enteDio = Network.instance.enteDio;
Future<void> init() async {
_prefs = await SharedPreferences.getInstance();
void init(SharedPreferences preferences) {
_prefs = preferences;
}
Future<void> syncTrash() async {

View file

@ -70,8 +70,8 @@ class FileUploader {
}
static FileUploader instance = FileUploader._privateConstructor();
Future<void> init(bool isBackground) async {
_prefs = await SharedPreferences.getInstance();
Future<void> init(SharedPreferences preferences, bool isBackground) async {
_prefs = preferences;
_isBackground = isBackground;
_processType =
isBackground ? ProcessType.background : ProcessType.foreground;

View file

@ -13,8 +13,8 @@ class LocalSettings {
static const kCollectionSortPref = "collection_sort_pref";
late SharedPreferences _prefs;
Future<void> init() async {
_prefs = await SharedPreferences.getInstance();
void init(SharedPreferences preferences) {
_prefs = preferences;
}
AlbumSortKey albumSortKey() {