From 6a186ef42085467db25eeaa7f0cf48b9beb94a42 Mon Sep 17 00:00:00 2001
From: Neeraj Gupta <254676+ua741@users.noreply.github.com>
Date: Sat, 11 May 2024 13:31:46 +0530
Subject: [PATCH] [server] Add option to updateMetadata without versionChange

---
 server/ente/file.go           |  1 +
 server/pkg/controller/file.go |  2 +-
 server/pkg/repo/file.go       | 10 +++++++++-
 3 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/server/ente/file.go b/server/ente/file.go
index 4a69473e3..a0e67c71c 100644
--- a/server/ente/file.go
+++ b/server/ente/file.go
@@ -134,6 +134,7 @@ type UpdateMagicMetadata struct {
 // UpdateMultipleMagicMetadataRequest request payload for updating magic metadata for list of files
 type UpdateMultipleMagicMetadataRequest struct {
 	MetadataList []UpdateMagicMetadata `json:"metadataList" binding:"required"`
+	SkipVersion  *bool                 `json:"skipVersion"`
 }
 
 // UploadURL represents the upload url for a specific object
diff --git a/server/pkg/controller/file.go b/server/pkg/controller/file.go
index d7a63d2a9..b3fec115d 100644
--- a/server/pkg/controller/file.go
+++ b/server/pkg/controller/file.go
@@ -502,7 +502,7 @@ func (c *FileController) UpdateMagicMetadata(ctx *gin.Context, req ente.UpdateMu
 	if err != nil {
 		return stacktrace.Propagate(err, "")
 	}
-	err = c.FileRepo.UpdateMagicAttributes(ctx, req.MetadataList, isPublicMetadata)
+	err = c.FileRepo.UpdateMagicAttributes(ctx, req.MetadataList, isPublicMetadata, req.SkipVersion)
 	if err != nil {
 		return stacktrace.Propagate(err, "failed to update magic attributes")
 	}
diff --git a/server/pkg/repo/file.go b/server/pkg/repo/file.go
index eafc7b570..2ae4eafdc 100644
--- a/server/pkg/repo/file.go
+++ b/server/pkg/repo/file.go
@@ -311,7 +311,12 @@ func (repo *FileRepository) Update(file ente.File, fileSize int64, thumbnailSize
 
 // UpdateMagicAttributes updates the magic attributes for the list of files and update collection_files & collection
 // which have this file.
-func (repo *FileRepository) UpdateMagicAttributes(ctx context.Context, fileUpdates []ente.UpdateMagicMetadata, isPublicMetadata bool) error {
+func (repo *FileRepository) UpdateMagicAttributes(
+	ctx context.Context,
+	fileUpdates []ente.UpdateMagicMetadata,
+	isPublicMetadata bool,
+	skipVersion *bool,
+) error {
 	updationTime := time.Microseconds()
 	tx, err := repo.DB.BeginTx(ctx, nil)
 	if err != nil {
@@ -336,6 +341,9 @@ func (repo *FileRepository) UpdateMagicAttributes(ctx context.Context, fileUpdat
 			return stacktrace.Propagate(err, "")
 		}
 	}
+	if skipVersion != nil && *skipVersion {
+		return tx.Commit()
+	}
 	// todo: full table scan, need to add index (for discussion: add user_id and idx {user_id, file_id}).
 	updatedRows, err := tx.QueryContext(ctx, `UPDATE collection_files 
 			SET updation_time = $1 WHERE file_id = ANY($2) AND is_deleted= false RETURNING collection_id`, updationTime,