From decc8d522eb8539ba6df4d2a5ade370e6bd21efb Mon Sep 17 00:00:00 2001 From: Abhinav Date: Sat, 8 Jul 2023 11:35:06 +0530 Subject: [PATCH 1/3] remove noFallthroughCasesInSwitch false --- apps/photos/tsconfig.json | 1 - 1 file changed, 1 deletion(-) diff --git a/apps/photos/tsconfig.json b/apps/photos/tsconfig.json index 988ef1a68..a9656d5cb 100644 --- a/apps/photos/tsconfig.json +++ b/apps/photos/tsconfig.json @@ -6,7 +6,6 @@ "jsx": "preserve", "jsxImportSource": "@emotion/react", "lib": ["dom", "dom.iterable", "esnext", "webworker"], - "noFallthroughCasesInSwitch": false, "noImplicitAny": false, "noUnusedLocals": false, "noUnusedParameters": false, From 85f59c2ee6f03392de80a6ba1bb6c77d58890dbe Mon Sep 17 00:00:00 2001 From: Abhinav Date: Sat, 8 Jul 2023 11:40:44 +0530 Subject: [PATCH 2/3] reenabled strictBindCallApply tsc check --- apps/photos/src/utils/billing/index.ts | 4 ++-- apps/photos/tsconfig.json | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/apps/photos/src/utils/billing/index.ts b/apps/photos/src/utils/billing/index.ts index edb25b151..cf70470af 100644 --- a/apps/photos/src/utils/billing/index.ts +++ b/apps/photos/src/utils/billing/index.ts @@ -163,7 +163,7 @@ export async function updateSubscription( export async function cancelSubscription( setDialogMessage: SetDialogBoxAttributes, - closePlanSelectorModal: () => null, + closePlanSelectorModal: () => void, setLoading: SetLoading ) { try { @@ -188,7 +188,7 @@ export async function cancelSubscription( export async function activateSubscription( setDialogMessage: SetDialogBoxAttributes, - closePlanSelectorModal: () => null, + closePlanSelectorModal: () => void, setLoading: SetLoading ) { try { diff --git a/apps/photos/tsconfig.json b/apps/photos/tsconfig.json index a9656d5cb..458580619 100644 --- a/apps/photos/tsconfig.json +++ b/apps/photos/tsconfig.json @@ -9,7 +9,6 @@ "noImplicitAny": false, "noUnusedLocals": false, "noUnusedParameters": false, - "strictBindCallApply": false, "strictNullChecks": false, "strictPropertyInitialization": false, "target": "es5", From 91879d0c2974401e872d5f715e3907296841721f Mon Sep 17 00:00:00 2001 From: Abhinav Date: Tue, 11 Jul 2023 12:31:57 +0530 Subject: [PATCH 3/3] removed "strictPropertyInitialization": false, --- apps/photos/tsconfig.json | 1 - 1 file changed, 1 deletion(-) diff --git a/apps/photos/tsconfig.json b/apps/photos/tsconfig.json index 458580619..cb4892469 100644 --- a/apps/photos/tsconfig.json +++ b/apps/photos/tsconfig.json @@ -10,7 +10,6 @@ "noUnusedLocals": false, "noUnusedParameters": false, "strictNullChecks": false, - "strictPropertyInitialization": false, "target": "es5", "useUnknownInCatchVariables": false },