chore: lint fixes

auth/lib/ui/account/recovery_page.dart

@@ -1,5 +1,3 @@
-import 'dart:ui';
-
 import 'package:ente_auth/core/configuration.dart';
 import 'package:ente_auth/l10n/l10n.dart';
 import 'package:ente_auth/ui/account/password_entry_page.dart';

auth/lib/ui/account/verify_recovery_page.dart

@@ -1,5 +1,3 @@
-import 'dart:ui';
-
 import 'package:bip39/bip39.dart' as bip39;
 import 'package:dio/dio.dart';
 import 'package:ente_auth/core/configuration.dart';

auth/lib/ui/settings/data/import/plain_text_import.dart

@@ -1,6 +1,5 @@
 import 'dart:async';
 import 'dart:io';
-import 'dart:ui';
 
 import 'package:ente_auth/ente_theme_data.dart';
 import 'package:ente_auth/l10n/l10n.dart';

auth/lib/ui/tools/debug/log_file_viewer.dart

@@ -1,5 +1,4 @@
 import 'dart:io';
-import 'dart:ui';
 
 import 'package:ente_auth/ui/common/loading_widget.dart';
 import 'package:ente_auth/utils/platform_util.dart';

auth/lib/ui/two_factor_recovery_page.dart

@@ -1,5 +1,3 @@
-import 'dart:ui';
-
 import 'package:ente_auth/l10n/l10n.dart';
 import 'package:ente_auth/services/user_service.dart';
 import 'package:ente_auth/utils/dialog_util.dart';

auth/lib/utils/date_time_util.dart

@@ -48,25 +48,17 @@ const searchStartYear = 1970;
 
 //Jun 2022
 String getMonthAndYear(DateTime dateTime) {
-  return _months[dateTime.month]! + " " + dateTime.year.toString();
+  return "${_months[dateTime.month]!} ${dateTime.year}";
 }
 
 //Thu, 30 Jun
 String getDayAndMonth(DateTime dateTime) {
-  return _days[dateTime.weekday]! +
-      ", " +
-      dateTime.day.toString() +
-      " " +
-      _months[dateTime.month]!;
+  return "${_days[dateTime.weekday]!}, ${dateTime.day} ${_months[dateTime.month]!}";
 }
 
 //30 Jun, 2022
 String getDateAndMonthAndYear(DateTime dateTime) {
-  return dateTime.day.toString() +
-      " " +
-      _months[dateTime.month]! +
-      ", " +
-      dateTime.year.toString();
+  return "${dateTime.day} ${_months[dateTime.month]!}, ${dateTime.year}";
 }
 
 String getDay(DateTime dateTime) {
@@ -87,13 +79,11 @@ String getAbbreviationOfYear(DateTime dateTime) {
 
 //14:32
 String getTime(DateTime dateTime) {
-  final hours = dateTime.hour > 9
-      ? dateTime.hour.toString()
-      : "0" + dateTime.hour.toString();
-  final minutes = dateTime.minute > 9
-      ? dateTime.minute.toString()
-      : "0" + dateTime.minute.toString();
-  return hours + ":" + minutes;
+  final hours =
+      dateTime.hour > 9 ? dateTime.hour.toString() : "0${dateTime.hour}";
+  final minutes =
+      dateTime.minute > 9 ? dateTime.minute.toString() : "0${dateTime.minute}";
+  return "$hours:$minutes";
 }
 
 //11:22 AM
@@ -103,41 +93,23 @@ String getTimeIn12hrFormat(DateTime dateTime) {
 
 //Thu, Jun 30, 2022 - 14:32
 String getFormattedTime(DateTime dateTime) {
-  return getDay(dateTime) +
-      ", " +
-      getMonth(dateTime) +
-      " " +
-      dateTime.day.toString() +
-      ", " +
-      dateTime.year.toString() +
-      " - " +
-      getTime(dateTime);
+  return "${getDay(dateTime)}, ${getMonth(dateTime)} ${dateTime.day}, ${dateTime.year} - ${getTime(dateTime)}";
 }
 
 //30 Jun'22
 String getFormattedDate(DateTime dateTime) {
-  return dateTime.day.toString() +
-      " " +
-      getMonth(dateTime) +
-      "'" +
-      getAbbreviationOfYear(dateTime);
+  return "${dateTime.day} ${getMonth(dateTime)}'${getAbbreviationOfYear(dateTime)}";
 }
 
 String getFullDate(DateTime dateTime) {
-  return getDay(dateTime) +
-      ", " +
-      getMonth(dateTime) +
-      " " +
-      dateTime.day.toString() +
-      " " +
-      dateTime.year.toString();
+  return "${getDay(dateTime)}, ${getMonth(dateTime)} ${dateTime.day} ${dateTime.year}";
 }
 
 String daysLeft(int futureTime) {
   final int daysLeft = ((futureTime - DateTime.now().microsecondsSinceEpoch) /
           Duration.microsecondsPerDay)
       .ceil();
-  return '$daysLeft day' + (daysLeft <= 1 ? "" : "s");
+  return '$daysLeft day${daysLeft <= 1 ? "" : "s"}';
 }
 
 String formatDuration(Duration position) {
@@ -168,7 +140,7 @@ String formatDuration(Duration position) {
           : '0$seconds';
 
   final formattedTime =
-      '${hoursString == '00' ? '' : hoursString + ':'}$minutesString:$secondsString';
+      '${hoursString == '00' ? '' : '$hoursString:'}$minutesString:$secondsString';
 
   return formattedTime;
 }
@@ -223,7 +195,7 @@ String getDayTitle(int timestamp) {
     }
   }
   if (date.year != DateTime.now().year) {
-    title += " " + date.year.toString();
+    title += " ${date.year}";
   }
   return title;
 }
@@ -233,14 +205,11 @@ String secondsToHHMMSS(int value) {
   h = value ~/ 3600;
   m = ((value - h * 3600)) ~/ 60;
   s = value - (h * 3600) - (m * 60);
-  final String hourLeft =
-      h.toString().length < 2 ? "0" + h.toString() : h.toString();
+  final String hourLeft = h.toString().length < 2 ? "0$h" : h.toString();
 
-  final String minuteLeft =
-      m.toString().length < 2 ? "0" + m.toString() : m.toString();
+  final String minuteLeft = m.toString().length < 2 ? "0$m" : m.toString();
 
-  final String secondsLeft =
-      s.toString().length < 2 ? "0" + s.toString() : s.toString();
+  final String secondsLeft = s.toString().length < 2 ? "0$s" : s.toString();
 
   final String result = "$hourLeft:$minuteLeft:$secondsLeft";
 

auth/lib/utils/platform_util.dart

@@ -78,7 +78,7 @@ class PlatformUtil {
           mimeType: type,
         );
       }
-    } catch (e) {}
+    } catch (_) {}
   }
 
   // Needed to fix issue with local_auth on Windows

auth/lib/utils/window_protocol_handler.dart

@@ -47,8 +47,8 @@ class WindowsProtocolHandler {
     }
   }
 
-  String _sanitize(String value) {
-    value = value.replaceAll(r'%s', '%1').replaceAll(r'"', '\\"');
-    return '"$value"';
-  }
+  // String _sanitize(String value) {
+  //   value = value.replaceAll(r'%s', '%1').replaceAll(r'"', '\\"');
+  //   return '"$value"';
+  // }
 }