From 4229223af5b73bd7924095fc318670bce9061e50 Mon Sep 17 00:00:00 2001 From: ashilkn Date: Thu, 16 Nov 2023 13:38:31 +0530 Subject: [PATCH] minor changes --- lib/ui/viewer/search/search_suggestions.dart | 1 + lib/ui/viewer/search/search_widget.dart | 20 ++++++++++---------- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/lib/ui/viewer/search/search_suggestions.dart b/lib/ui/viewer/search/search_suggestions.dart index 91ee3dd83..eac86ce17 100644 --- a/lib/ui/viewer/search/search_suggestions.dart +++ b/lib/ui/viewer/search/search_suggestions.dart @@ -21,6 +21,7 @@ class SearchSuggestionsWidget extends StatelessWidget { Widget build(BuildContext context) { late final String title; final resultsCount = results.length; + //todo: extract string if (resultsCount == 1) { title = "$resultsCount result found"; } else { diff --git a/lib/ui/viewer/search/search_widget.dart b/lib/ui/viewer/search/search_widget.dart index 04192f4b2..efe4c828f 100644 --- a/lib/ui/viewer/search/search_widget.dart +++ b/lib/ui/viewer/search/search_widget.dart @@ -74,6 +74,16 @@ class SearchWidgetState extends State { } } + @override + void dispose() { + _debouncer.cancelDebounce(); + focusNode.dispose(); + _tabDoubleTapEvent?.cancel(); + textController.removeListener(textControllerListener); + textController.dispose(); + super.dispose(); + } + Future textControllerListener() async { //query in local varialbe final value = textController.text; @@ -179,16 +189,6 @@ class SearchWidgetState extends State { ); } - @override - void dispose() { - _debouncer.cancelDebounce(); - focusNode.dispose(); - _tabDoubleTapEvent?.cancel(); - textController.removeListener(textControllerListener); - textController.dispose(); - super.dispose(); - } - Future> getSearchResultsForQuery( BuildContext context, String query,