Merge pull request #910 from ente-io/fix-shift-event-listener-cleanup
fix shift key event listener cleanup
This commit is contained in:
commit
3eda945a3d
|
@ -273,6 +273,7 @@ const PhotoFrame = ({
|
||||||
};
|
};
|
||||||
document.addEventListener('keydown', handleKeyDown, false);
|
document.addEventListener('keydown', handleKeyDown, false);
|
||||||
document.addEventListener('keyup', handleKeyUp, false);
|
document.addEventListener('keyup', handleKeyUp, false);
|
||||||
|
|
||||||
router.events.on('hashChangeComplete', (url: string) => {
|
router.events.on('hashChangeComplete', (url: string) => {
|
||||||
const start = url.indexOf('#');
|
const start = url.indexOf('#');
|
||||||
const hash = url.slice(start !== -1 ? start : url.length);
|
const hash = url.slice(start !== -1 ? start : url.length);
|
||||||
|
@ -285,9 +286,10 @@ const PhotoFrame = ({
|
||||||
setOpen(false);
|
setOpen(false);
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
return () => {
|
return () => {
|
||||||
document.addEventListener('keydown', handleKeyDown, false);
|
document.removeEventListener('keydown', handleKeyDown, false);
|
||||||
document.addEventListener('keyup', handleKeyUp, false);
|
document.removeEventListener('keyup', handleKeyUp, false);
|
||||||
};
|
};
|
||||||
}, []);
|
}, []);
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue