beenull/ente
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Merge pull request #910 from ente-io/fix-shift-event-listener-cleanup

Browse source 
fix shift key event listener cleanup
This commit is contained in:
Abhinav Kumar 2023-02-02 18:31:28 +05:30 committed by GitHub
parent 7398538bae e91eb479ef
commit 3eda945a3d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/components/PhotoFrame.tsx
View file

@ -273,6 +273,7 @@ const PhotoFrame = ({
};
document.addEventListener('keydown', handleKeyDown, false);
document.addEventListener('keyup', handleKeyUp, false);
router.events.on('hashChangeComplete', (url: string) => {
const start = url.indexOf('#');
const hash = url.slice(start !== -1 ? start : url.length);
@ -285,9 +286,10 @@ const PhotoFrame = ({
setOpen(false);
}
});
return () => {
document.addEventListener('keydown', handleKeyDown, false);
document.addEventListener('keyup', handleKeyUp, false);
document.removeEventListener('keydown', handleKeyDown, false);
document.removeEventListener('keyup', handleKeyUp, false);
};
}, []);