From 3069650c94b590856bfa7e32364facf70534bad0 Mon Sep 17 00:00:00 2001
From: Abhinav <abhinavk.grd@gmail.com>
Date: Mon, 10 Oct 2022 14:06:47 +0530
Subject: [PATCH] add button labels and move delete button

---
 src/components/PhotoSwipe/index.tsx    | 25 ++++++++++++++++---------
 src/utils/strings/englishConstants.tsx |  2 ++
 2 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/src/components/PhotoSwipe/index.tsx b/src/components/PhotoSwipe/index.tsx
index 610fbd155..31e6afc5d 100644
--- a/src/components/PhotoSwipe/index.tsx
+++ b/src/components/PhotoSwipe/index.tsx
@@ -376,6 +376,16 @@ function PhotoSwipe(props: Iprops) {
                                 className="pswp__button pswp__button--close"
                                 title={constants.CLOSE}
                             />
+                            <button
+                                className="pswp__button pswp__button--custom"
+                                title={constants.DELETE}
+                                onClick={() => {
+                                    confirmTrashFile(
+                                        photoSwipe?.currItem as EnteFile
+                                    );
+                                }}>
+                                <DeleteIcon fontSize="small" />
+                            </button>
 
                             {props.enableDownload && (
                                 <button
@@ -398,6 +408,11 @@ function PhotoSwipe(props: Iprops) {
                             {!props.isSharedCollection &&
                                 !props.isTrashCollection && (
                                     <button
+                                        title={
+                                            isFav
+                                                ? constants.UNFAVORITE
+                                                : constants.FAVORITE
+                                        }
                                         className="pswp__button pswp__button--custom"
                                         onClick={() => {
                                             onFavClick(photoSwipe?.currItem);
@@ -409,15 +424,7 @@ function PhotoSwipe(props: Iprops) {
                                         )}
                                     </button>
                                 )}
-                            <button
-                                className="pswp__button pswp__button--custom"
-                                onClick={() => {
-                                    confirmTrashFile(
-                                        photoSwipe?.currItem as EnteFile
-                                    );
-                                }}>
-                                <DeleteIcon fontSize="small" />
-                            </button>
+
                             {!props.isSharedCollection && (
                                 <button
                                     className="pswp__button pswp__button--custom"
diff --git a/src/utils/strings/englishConstants.tsx b/src/utils/strings/englishConstants.tsx
index 1d4a2895d..efbd44537 100644
--- a/src/utils/strings/englishConstants.tsx
+++ b/src/utils/strings/englishConstants.tsx
@@ -154,6 +154,8 @@ const englishConstants = {
         'Selected files will be permanently deleted from your ente account.',
     DELETE_FILE: 'Delete files',
     DELETE: 'Delete',
+    FAVORITE: 'Favorite',
+    UNFAVORITE: 'Unfavorite',
     MULTI_FOLDER_UPLOAD: 'Multiple folders detected',
     UPLOAD_STRATEGY_CHOICE: 'Would you like to upload them into',
     UPLOAD_STRATEGY_SINGLE_COLLECTION: 'A single album',