beenull/ente
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Merge pull request #887 from ente-io/text_input_dialog_bug

Browse source 
Bug fix: Option to obscure text coming up in every TextInputwidget
This commit is contained in:
Neeraj Gupta 2023-02-23 20:43:53 +05:30 committed by GitHub
parent 5b5a52e79a 9d161fe239
commit 2ad667deb1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/ui/components/text_input_widget.dart
View file

@ -142,6 +142,7 @@ class _TextInputWidgetState extends State<TextInputWidget> {
shouldSurfaceExecutionStates:
widget.shouldSurfaceExecutionStates,
obscureTextNotifier: _obscureTextNotifier,
isPasswordInput: widget.isPasswordInput,
),
),
),
@ -294,10 +295,12 @@ class SuffixIconWidget extends StatelessWidget {
final ExecutionState executionState;
final bool shouldSurfaceExecutionStates;
final ValueNotifier? obscureTextNotifier;
final bool isPasswordInput;
const SuffixIconWidget({
required this.executionState,
required this.shouldSurfaceExecutionStates,
this.obscureTextNotifier,
this.isPasswordInput = false,
super.key,
});
@ -307,7 +310,8 @@ class SuffixIconWidget extends StatelessWidget {
final colorScheme = getEnteColorScheme(context);
if (executionState == ExecutionState.idle ||
!shouldSurfaceExecutionStates) {
if (obscureTextNotifier != null) {
if (isPasswordInput) {
assert(obscureTextNotifier != null);
trailingWidget = GestureDetector(
onTap: () {
obscureTextNotifier!.value = !obscureTextNotifier!.value;