From 22e33737e8f95fce611627ba9ccc6a3ba0e9e58c Mon Sep 17 00:00:00 2001
From: Manav Rathi <manav@mrmr.io>
Date: Wed, 8 May 2024 14:02:23 +0530
Subject: [PATCH] Forego checks if client doesn't follow the protocol

---
 web/apps/cast/src/services/pair.ts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/web/apps/cast/src/services/pair.ts b/web/apps/cast/src/services/pair.ts
index ddaaba7e0..0364cf491 100644
--- a/web/apps/cast/src/services/pair.ts
+++ b/web/apps/cast/src/services/pair.ts
@@ -132,8 +132,8 @@ export const advertiseCode = (
     // request for a different collection ID, restart the app to allow them to
     // reconnect using a freshly generated pairing code.
     //
-    // If the request does not have a collectionID, just keep a boolean flag.
-    let pairedCollectionID: string | boolean | undefined;
+    // If the request does not have a collectionID, forego this check.
+    let pairedCollectionID: string | undefined;
 
     type ListenerProps = {
         senderId: string;
@@ -150,19 +150,19 @@ export const advertiseCode = (
             context.stop();
         };
 
-        const cid =
+        const collectionID =
             data &&
             typeof data == "object" &&
             typeof data["collectionID"] == "string"
                 ? data["collectionID"]
                 : undefined;
 
-        if (pairedCollectionID !== undefined && pairedCollectionID != cid) {
-            restart(`incoming request for a new collection ${cid}`);
+        if (pairedCollectionID && pairedCollectionID != collectionID) {
+            restart(`incoming request for a new collection ${collectionID}`);
             return;
         }
 
-        pairedCollectionID = cid ?? true;
+        pairedCollectionID = collectionID;
 
         const code = pairingCode();
         if (!code) {