diff --git a/lib/ui/viewer/gallery/collection_page.dart b/lib/ui/viewer/gallery/collection_page.dart index 6afc7c662..cbd3c522d 100644 --- a/lib/ui/viewer/gallery/collection_page.dart +++ b/lib/ui/viewer/gallery/collection_page.dart @@ -74,7 +74,7 @@ class CollectionPage extends StatelessWidget { selectedFiles: _selectedFiles, initialFiles: initialFiles, albumName: c.collection.name, - sortOrderAsc: c.collection.pubMagicMetadata.asc ?? false, + sortAsyncFn: () => c.collection.pubMagicMetadata.asc ?? false, ); return Scaffold( appBar: PreferredSize( diff --git a/lib/ui/viewer/gallery/gallery.dart b/lib/ui/viewer/gallery/gallery.dart index 403146a32..22c9c5a6d 100644 --- a/lib/ui/viewer/gallery/gallery.dart +++ b/lib/ui/viewer/gallery/gallery.dart @@ -25,6 +25,8 @@ typedef GalleryLoader = Future Function( bool? asc, }); +typedef SortAscFn = bool Function(); + class Gallery extends StatefulWidget { final GalleryLoader asyncLoader; final List? initialFiles; @@ -42,7 +44,9 @@ class Gallery extends StatefulWidget { final Widget loadingWidget; final bool disableScroll; final bool limitSelectionToOne; - final bool sortOrderAsc; + + // add a Function variable to get sort value in bool + final SortAscFn? sortAsyncFn; const Gallery({ required this.asyncLoader, @@ -61,7 +65,7 @@ class Gallery extends StatefulWidget { this.loadingWidget = const EnteLoadingWidget(), this.disableScroll = false, this.limitSelectionToOne = false, - this.sortOrderAsc = false, + this.sortAsyncFn, Key? key, }) : super(key: key); @@ -84,6 +88,7 @@ class _GalleryState extends State { StreamSubscription? _tabDoubleTapEvent; final _forceReloadEventSubscriptions = >[]; late String _logTag; + bool _sortOrderAsc = false; @override void initState() { @@ -91,6 +96,7 @@ class _GalleryState extends State { "Gallery_${widget.tagPrefix}${kDebugMode ? "_" + widget.albumName! : ""}"; _logger = Logger(_logTag); _logger.finest("init Gallery"); + _sortOrderAsc = widget.sortAsyncFn != null ? widget.sortAsyncFn!() : false; _itemScroller = ItemScrollController(); if (widget.reloadEvent != null) { _reloadEventSubscription = widget.reloadEvent!.listen((event) async { @@ -122,13 +128,15 @@ class _GalleryState extends State { _forceReloadEventSubscriptions.add( event.listen((event) async { _logger.finest("Force refresh all files on ${event.reason}"); + _sortOrderAsc = + widget.sortAsyncFn != null ? widget.sortAsyncFn!() : false; final result = await _loadFiles(); _setFilesAndReload(result.files); }), ); } } - if (widget.initialFiles != null && !widget.sortOrderAsc) { + if (widget.initialFiles != null && !_sortOrderAsc) { _onFilesLoaded(widget.initialFiles!); } _loadFiles(limit: kInitialLoadLimit).then((result) async { @@ -156,7 +164,7 @@ class _GalleryState extends State { galleryLoadStartTime, galleryLoadEndTime, limit: limit, - asc: widget.sortOrderAsc, + asc: _sortOrderAsc, ); final endTime = DateTime.now().microsecondsSinceEpoch; final duration = Duration(microseconds: endTime - startTime); @@ -216,7 +224,7 @@ class _GalleryState extends State { disableScroll: widget.disableScroll, emptyState: widget.emptyState, asyncLoader: widget.asyncLoader, - sortOrderAsc: widget.sortOrderAsc, + sortOrderAsc: _sortOrderAsc, removalEventTypes: widget.removalEventTypes, tagPrefix: widget.tagPrefix, scrollBottomSafeArea: widget.scrollBottomSafeArea, @@ -248,7 +256,7 @@ class _GalleryState extends State { if (dailyFiles.isNotEmpty) { collatedFiles.add(dailyFiles); } - if (widget.sortOrderAsc) { + if (_sortOrderAsc) { collatedFiles .sort((a, b) => a[0].creationTime!.compareTo(b[0].creationTime!)); } else {