diff --git a/cmd/crowdsec-cli/main.go b/cmd/crowdsec-cli/main.go index 9f80c70c5..07c3474df 100644 --- a/cmd/crowdsec-cli/main.go +++ b/cmd/crowdsec-cli/main.go @@ -93,7 +93,9 @@ API interaction: Args: cobra.ExactArgs(0), Hidden: true, Run: func(cmd *cobra.Command, args []string) { - doc.GenMarkdownTree(rootCmd, "./doc/") + if err := doc.GenMarkdownTree(rootCmd, "./doc/"); err != nil { + log.Fatalf("Failed to generate cobra doc") + } }, } rootCmd.AddCommand(cmdDocGen) diff --git a/cmd/crowdsec/serve.go b/cmd/crowdsec/serve.go index 61a07600e..cbdd8486a 100644 --- a/cmd/crowdsec/serve.go +++ b/cmd/crowdsec/serve.go @@ -69,7 +69,7 @@ func serveDaemon() error { if d != nil { return nil } - defer daemonCTX.Release() + defer daemonCTX.Release() //nolint:errcheck err = daemon.ServeSignals() if err != nil { return fmt.Errorf("serveDaemon error : %s", err.Error()) diff --git a/pkg/cwapi/auth.go b/pkg/cwapi/auth.go index ee9a49f17..a08fe1358 100644 --- a/pkg/cwapi/auth.go +++ b/pkg/cwapi/auth.go @@ -113,7 +113,7 @@ func (ctx *ApiCtx) Init(cfg string, profile string) error { return err } //start the background go-routine - go ctx.pushLoop() + go ctx.pushLoop() //nolint:errcheck return nil } diff --git a/pkg/leakybucket/buckets_test.go b/pkg/leakybucket/buckets_test.go index 1787fe818..3353780d7 100644 --- a/pkg/leakybucket/buckets_test.go +++ b/pkg/leakybucket/buckets_test.go @@ -216,7 +216,6 @@ POLL_AGAIN: continue } else { log.Infof("(scenario) %s == %s", out.Overflow.Scenario, expected.Overflow.Scenario) - valid = true } //Events_count if out.Overflow.Events_count != expected.Overflow.Events_count { @@ -225,7 +224,6 @@ POLL_AGAIN: continue } else { log.Infof("(Events_count) %d == %d", out.Overflow.Events_count, expected.Overflow.Events_count) - valid = true } //Source_ip if out.Overflow.Source_ip != expected.Overflow.Source_ip { @@ -234,7 +232,6 @@ POLL_AGAIN: continue } else { log.Infof("(Source_ip) %s == %s", out.Overflow.Source_ip, expected.Overflow.Source_ip) - valid = true } //CheckFailed: diff --git a/pkg/parser/node.go b/pkg/parser/node.go index 1c7d2127c..c96a40bd8 100644 --- a/pkg/parser/node.go +++ b/pkg/parser/node.go @@ -108,7 +108,7 @@ func (n *Node) validate(pctx *UnixParserCtx) error { } func (n *Node) process(p *types.Event, ctx UnixParserCtx) (bool, error) { - var NodeState bool = true + var NodeState bool clog := n.logger clog.Debugf("Event entering node") @@ -124,7 +124,6 @@ func (n *Node) process(p *types.Event, ctx UnixParserCtx) (bool, error) { case bool: /* filter returned false, don't process Node */ if !out { - NodeState = false clog.Debugf("eval(FALSE) '%s'", n.Filter) clog.Debugf("Event leaving node : ko") return false, nil @@ -132,7 +131,6 @@ func (n *Node) process(p *types.Event, ctx UnixParserCtx) (bool, error) { default: clog.Warningf("Expr '%s' returned non-bool, abort : %T", n.Filter, output) clog.Debugf("Event leaving node : ko") - NodeState = false return false, nil } NodeState = true @@ -424,10 +422,7 @@ func (n *Node) compile(pctx *UnixParserCtx) error { err = n.SuccessNodes[idx].compile(pctx) if err != nil { return err - } else { - //n.logger.Debugf("Leaf compilation suceeded: %v\n", n.SuccessNodes[idx]) } - //set child node to parent stage } valid = true } diff --git a/pkg/parser/runtime.go b/pkg/parser/runtime.go index 702356120..b255f21c0 100644 --- a/pkg/parser/runtime.go +++ b/pkg/parser/runtime.go @@ -228,8 +228,8 @@ func stageidx(stage string, stages []string) int { } func /*(u types.UnixParser)*/ Parse(ctx UnixParserCtx, xp types.Event, nodes []Node) (types.Event, error) { - var event types.Event - event = xp + var event types.Event = xp + /* the stage is undefined, probably line is freshly acquired, set to first stage !*/ if event.Stage == "" && len(ctx.Stages) > 0 { event.Stage = ctx.Stages[0] diff --git a/plugins/backend/sqlite.go b/plugins/backend/sqlite.go index db711aeec..7db8e2aa2 100644 --- a/plugins/backend/sqlite.go +++ b/plugins/backend/sqlite.go @@ -8,6 +8,7 @@ import ( log "github.com/sirupsen/logrus" ) +//nolint:unused // pluginDB is the interface for sqlite output plugin type pluginDB struct { CTX *sqlite.Context } @@ -65,6 +66,7 @@ func (p *pluginDB) ReadAT(timeAT time.Time) ([]map[string]string, error) { return ret, nil } +//nolint:unused // New is used by the plugin system func New() interface{} { return &pluginDB{} }