log more information if server returns non 200 status code (#966)

This commit is contained in:
blotus 2021-09-10 14:24:17 +02:00 committed by GitHub
parent e651379964
commit dd41c30fba
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -61,23 +61,29 @@ func (s *HTTPPlugin) Notify(ctx context.Context, notification *protobufs.Notific
} }
for headerName, headerValue := range cfg.Headers { for headerName, headerValue := range cfg.Headers {
logger.Debug(fmt.Sprintf("adding header %s: %s", headerName, headerValue))
request.Header.Add(headerName, headerValue) request.Header.Add(headerName, headerValue)
} }
logger.Debug(fmt.Sprintf("making HTTP %s call to %s with body %s", cfg.Method, cfg.URL, string(notification.Text))) logger.Debug(fmt.Sprintf("making HTTP %s call to %s with body %s", cfg.Method, cfg.URL, string(notification.Text)))
resp, err := client.Do(request) resp, err := client.Do(request)
if err != nil { if err != nil {
logger.Error(fmt.Sprintf("Failed to make HTTP request : %s", err))
return nil, err return nil, err
} }
defer resp.Body.Close()
if resp.StatusCode != 200 {
return nil, err
}
respData, err := ioutil.ReadAll(resp.Body) respData, err := ioutil.ReadAll(resp.Body)
if err != nil { if err != nil {
return &protobufs.Empty{}, fmt.Errorf("failed to read response body got error %s", string(err.Error())) return nil, fmt.Errorf("failed to read response body got error %s", string(err.Error()))
} }
logger.Debug(fmt.Sprintf("got response %s", string(respData))) logger.Debug(fmt.Sprintf("got response %s", string(respData)))
if resp.StatusCode != 200 {
logger.Warn(fmt.Sprintf("HTTP server returned non 200 status code: %d", resp.StatusCode))
return &protobufs.Empty{}, nil
}
return &protobufs.Empty{}, nil return &protobufs.Empty{}, nil
} }