From c2d542983e169862090b3b8c47df65db0d74f97a Mon Sep 17 00:00:00 2001 From: marco Date: Mon, 29 Apr 2024 23:04:28 +0200 Subject: [PATCH] enable linter "revive" --- .golangci.yml | 120 +++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 119 insertions(+), 1 deletion(-) diff --git a/.golangci.yml b/.golangci.yml index 9f059aa8a..57e3255ba 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -118,6 +118,124 @@ linters-settings: - pkg: "gopkg.in/yaml.v2" desc: "yaml.v2 is deprecated for new code in favor of yaml.v3" + revive: + ignore-generated-header: true + severity: error + enable-all-rules: true + rules: + - name: add-constant + disabled: true + - name: argument-limit + disabled: true + - name: bare-return + disabled: true + - name: blank-imports + disabled: true + - name: bool-literal-in-expr + disabled: true + - name: cognitive-complexity + disabled: true + - name: comment-spacings + disabled: true + - name: confusing-naming + disabled: true + - name: confusing-results + disabled: true + - name: context-as-argument + disabled: true + - name: cyclomatic + disabled: true + - name: deep-exit + disabled: true + - name: defer + disabled: true + - name: duplicated-imports + disabled: true + - name: early-return + disabled: true + - name: empty-block + disabled: true + - name: empty-lines + disabled: true + - name: error-naming + disabled: true + - name: error-strings + disabled: true + - name: flag-parameter + disabled: true + - name: function-result-limit + disabled: true + - name: function-length + disabled: true + - name: get-return + disabled: true + - name: if-return + disabled: true + - name: increment-decrement + disabled: true + - name: indent-error-flow + disabled: true + - name: import-alias-naming + disabled: true + - name: import-shadowing + disabled: true + - name: line-length-limit + disabled: true + - name: max-control-nesting + disabled: true + - name: max-public-structs + disabled: true + - name: modifies-parameter + disabled: true + - name: modifies-value-receiver + disabled: true + - name: optimize-operands-order + disabled: true + - name: nested-structs + disabled: true + - name: package-comments + disabled: true + - name: range-val-address + disabled: true + - name: redundant-import-alias + disabled: true + - name: struct-tag + disabled: true + - name: superfluous-else + disabled: true + - name: time-equal + disabled: true + - name: var-naming + disabled: true + - name: var-declaration + disabled: true + - name: unchecked-type-assertion + disabled: true + - name: exported + disabled: true + - name: unexported-naming + disabled: true + - name: unexported-return + disabled: true + - name: unhandled-error + disabled: true + arguments: + - "fmt.Print" + - "fmt.Printf" + - "fmt.Println" + - name: unnecessary-stmt + disabled: true + - name: unreachable-code + disabled: true + - name: unused-parameter + disabled: true + - name: unused-receiver + disabled: true + - name: use-any + disabled: true + - name: useless-break + disabled: true + wsl: # Allow blocks to end with comments allow-trailing-comment: true @@ -198,6 +316,7 @@ linters: # - perfsprint # Checks that fmt.Sprintf can be replaced with a faster alternative. # - predeclared # find code that shadows one of Go's predeclared identifiers # - reassign # Checks that package variables are not reassigned + # - revive # Fast, configurable, extensible, flexible, and beautiful linter for Go. Drop-in replacement of golint. # - rowserrcheck # checks whether Rows.Err of rows is checked successfully # - sloglint # ensure consistent code style when using log/slog # - spancheck # Checks for mistakes with OpenTelemetry/Census spans. @@ -229,7 +348,6 @@ linters: - musttag # enforce field tags in (un)marshaled structs - promlinter # Check Prometheus metrics naming via promlint - protogetter # Reports direct reads from proto message fields when getters should be used - - revive # Fast, configurable, extensible, flexible, and beautiful linter for Go. Drop-in replacement of golint. - tagalign # check that struct tags are well aligned - thelper # thelper detects tests helpers which is not start with t.Helper() method. - wrapcheck # Checks that errors returned from external packages are wrapped