From 76e361208893ef950ae450bf83c6534ded0d4f1f Mon Sep 17 00:00:00 2001 From: Shivam Sandbhor Date: Tue, 8 Feb 2022 20:10:01 +0530 Subject: [PATCH] Check log level before dumping resp (#1243) * Check log level before dumping resp * Sleep longer in func tests Signed-off-by: Shivam Sandbhor --- pkg/apiclient/client_http.go | 14 ++++++++------ scripts/func_tests/tests_post-install_0base.sh | 2 +- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/pkg/apiclient/client_http.go b/pkg/apiclient/client_http.go index a47ad3b20..bfe328b97 100644 --- a/pkg/apiclient/client_http.go +++ b/pkg/apiclient/client_http.go @@ -84,13 +84,15 @@ func (c *ApiClient) Do(ctx context.Context, req *http.Request, v interface{}) (* return newResponse(resp), err } - for k, v := range resp.Header { - log.Debugf("[headers] %s : %s", k, v) - } + if log.GetLevel() >= log.DebugLevel { + for k, v := range resp.Header { + log.Debugf("[headers] %s : %s", k, v) + } - dump, err := httputil.DumpResponse(resp, true) - if err == nil { - log.Debugf("Response: %s", string(dump)) + dump, err := httputil.DumpResponse(resp, true) + if err == nil { + log.Debugf("Response: %s", string(dump)) + } } response := newResponse(resp) diff --git a/scripts/func_tests/tests_post-install_0base.sh b/scripts/func_tests/tests_post-install_0base.sh index 8c631d794..523173054 100755 --- a/scripts/func_tests/tests_post-install_0base.sh +++ b/scripts/func_tests/tests_post-install_0base.sh @@ -38,7 +38,7 @@ ${CSCLI} version || fail "cannot run cscli version" ## alerts # alerts list at startup should just return one entry : community pull -sleep 5 +sleep 40 ${CSCLI} alerts list -ojson | ${JQ} '. | length >= 1' || fail "expected at least one entry from cscli alerts list" ## capi ${CSCLI} capi status || fail "capi status should be ok"