From 18764eff0edae53c5456718d17a1d268e60e864c Mon Sep 17 00:00:00 2001 From: mmetc <92726601+mmetc@users.noreply.github.com> Date: Mon, 5 Jun 2023 13:02:37 +0200 Subject: [PATCH] make: allow using a development version of Go, with a warning (#2260) --- Makefile | 3 +++ mk/goversion.mk | 16 ++++++++++++---- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 334e738c8..52d5e3efe 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,8 @@ include mk/platform.mk +BUILD_REQUIRE_GO_MAJOR ?= 1 +BUILD_REQUIRE_GO_MINOR ?= 20 + BUILD_CODENAME ?= alphaga CROWDSEC_FOLDER = ./cmd/crowdsec diff --git a/mk/goversion.mk b/mk/goversion.mk index 48979ac8e..dd9954928 100644 --- a/mk/goversion.mk +++ b/mk/goversion.mk @@ -1,7 +1,4 @@ -BUILD_REQUIRE_GO_MAJOR ?= 1 -BUILD_REQUIRE_GO_MINOR ?= 20 - BUILD_GOVERSION = $(subst go,,$(shell go env GOVERSION)) go_major_minor = $(subst ., ,$(BUILD_GOVERSION)) @@ -10,8 +7,19 @@ GO_MINOR_VERSION = $(word 2, $(go_major_minor)) GO_VERSION_VALIDATION_ERR_MSG = Golang version ($(BUILD_GOVERSION)) is not supported, please use at least $(BUILD_REQUIRE_GO_MAJOR).$(BUILD_REQUIRE_GO_MINOR) + .PHONY: goversion -goversion: +goversion: $(if $(findstring devel,$(shell go env GOVERSION)),goversion_devel,goversion_check) + + +.PHONY: goversion_devel +goversion_devel: + $(warning WARNING: You are using a development version of Golang ($(BUILD_GOVERSION)) which is not supported. For production environments, use a stable version (at least $(BUILD_REQUIRE_GO_MAJOR).$(BUILD_REQUIRE_GO_MINOR))) + $(info ) + + +.PHONY: goversion_check +goversion_check: ifneq ($(OS), Windows_NT) @if [ $(GO_MAJOR_VERSION) -gt $(BUILD_REQUIRE_GO_MAJOR) ]; then \ exit 0; \