From df90d9f68c4dcad6602945192cbbcaf0719e5d77 Mon Sep 17 00:00:00 2001 From: Jakub Vrana Date: Sun, 15 Jul 2018 20:09:48 +0200 Subject: [PATCH] Reset event handlers after cloning (thanks to Salko) --- adminer/static/editing.js | 4 ++-- changes.txt | 1 + editor/static/editing.js | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/adminer/static/editing.js b/adminer/static/editing.js index fe315709..25d8c49e 100644 --- a/adminer/static/editing.js +++ b/adminer/static/editing.js @@ -509,8 +509,8 @@ function dumpClick(event) { * @this HTMLSelectElement */ function foreignAddRow() { - this.onchange = function () { }; var row = cloneNode(parentTag(this, 'tr')); + this.onchange = function () { }; var selects = qsa('select', row); for (var i=0; i < selects.length; i++) { selects[i].name = selects[i].name.replace(/\]/, '1$&'); @@ -525,8 +525,8 @@ function foreignAddRow() { * @this HTMLSelectElement */ function indexesAddRow() { - this.onchange = function () { }; var row = cloneNode(parentTag(this, 'tr')); + this.onchange = function () { }; var selects = qsa('select', row); for (var i=0; i < selects.length; i++) { selects[i].name = selects[i].name.replace(/indexes\[\d+/, '$&1'); diff --git a/changes.txt b/changes.txt index af1990ed..38fd81eb 100644 --- a/changes.txt +++ b/changes.txt @@ -1,5 +1,6 @@ Adminer 4.6.4-dev: Fix inline editing of empty cells (regression from 4.6.3) +Allow adding more than two indexes and forign key columns at a time (regression from 4.4.0) Adminer 4.6.3 (released 2018-06-28): Disallow using password-less databases diff --git a/editor/static/editing.js b/editor/static/editing.js index 5b3a7b93..09ba40a8 100644 --- a/editor/static/editing.js +++ b/editor/static/editing.js @@ -55,8 +55,8 @@ function whisperClick(event) { * @this HTMLInputElement */ function emailFileChange() { - this.onchange = function () { }; var el = this.cloneNode(true); + this.onchange = function () { }; el.value = ''; this.parentNode.appendChild(el); }