beenull/adminerevo
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Improve limit check in edit-foreign plugin

Browse source 
The limit is enforced in the query to prevent out-of-memory errors for big target tables.
This commit is contained in:
Jiří Barouš 2016-04-26 12:31:40 +02:00 committed by Jakub Vrana
parent 28a84fec18
commit d00927ce66
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
plugins/edit-foreign.php
View file

@ -30,7 +30,7 @@ class AdminerEditForeign {
if (preg_match('~binary~', $field["type"])) {
$column = "HEX($column)";
}
$options = array("" => "") + get_vals("SELECT $column FROM " . table($target) . " ORDER BY 1");
$options = array("" => "") + get_vals("SELECT $column FROM " . table($target) . " ORDER BY 1" . ($this->_limit ? " LIMIT " . ($this->_limit + 1) : ""));
if ($this->_limit && count($options) - 1 > $this->_limit) {
return;
}