From b90efd67069655618748542a88986d0dc451d774 Mon Sep 17 00:00:00 2001 From: jakubvrana Date: Tue, 16 Sep 2008 14:49:22 +0000 Subject: [PATCH] Escape order by function (thanks to Kajman) git-svn-id: https://adminer.svn.sourceforge.net/svnroot/adminer/trunk@487 7c3ca157-0c34-0410-bff1-cbf682f78f5c --- select.inc.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/select.inc.php b/select.inc.php index ccf75a68..9b378f63 100644 --- a/select.inc.php +++ b/select.inc.php @@ -49,10 +49,8 @@ foreach ((array) $_GET["where"] as $val) { } $order = array(); foreach ((array) $_GET["order"] as $key => $val) { - if (in_array($val, $columns, true)) { + if (in_array($val, $columns, true) || preg_match('(^(COUNT\\(\\*\\)|(' . strtoupper(implode('|', $functions) . '|' . implode('|', $grouping)) . ')\\((' . implode('|', array_map('preg_quote', array_map('idf_escape', $columns))) . ')\\))$)', $val)) { $order[] = idf_escape($val) . (isset($_GET["desc"][$key]) ? " DESC" : ""); - } elseif (preg_match('(^(COUNT\\(\\*\\)|(' . strtoupper(implode('|', $functions) . '|' . implode('|', $grouping)) . ')\\((' . implode('|', array_map('preg_quote', array_map('idf_escape', $columns))) . ')\\))$)', $val)) { - $order[] = $val . (isset($_GET["desc"][$key]) ? " DESC" : ""); } } $limit = (isset($_GET["limit"]) ? $_GET["limit"] : "30");