diff --git a/adminer/drivers/mssql.inc.php b/adminer/drivers/mssql.inc.php index d926ff7b..84b08534 100644 --- a/adminer/drivers/mssql.inc.php +++ b/adminer/drivers/mssql.inc.php @@ -436,16 +436,16 @@ WHERE OBJECT_NAME(i.object_id) = " . q($table) $index = array(); $drop = array(); foreach ($alter as $val) { - if ($val[2]) { + if ($val[2] == "DROP") { if ($val[0] == "PRIMARY") { //! sometimes used also for UNIQUE - $drop[] = $val[1]; + $drop[] = idf_escape($val[1]); } else { - $index[] = "$val[1] ON " . table($table); + $index[] = idf_escape($val[1]) . " ON " . table($table); } } elseif (!queries(($val[0] != "PRIMARY" - ? "CREATE" . ($val[0] != "INDEX" ? " UNIQUE" : "") . " INDEX " . idf_escape(uniqid($table . "_")) . " ON " . table($table) + ? "CREATE $val[0] " . ($val[0] != "INDEX" ? "INDEX " : "") . idf_escape($val[1] != "" ? $val[1] : uniqid($table . "_")) . " ON " . table($table) : "ALTER TABLE " . table($table) . " ADD PRIMARY KEY" - ) . " $val[1]")) { + ) . " $val[2]")) { return false; } } diff --git a/adminer/drivers/mysql.inc.php b/adminer/drivers/mysql.inc.php index 6c074157..78604545 100644 --- a/adminer/drivers/mysql.inc.php +++ b/adminer/drivers/mysql.inc.php @@ -611,12 +611,15 @@ if (!defined("DRIVER")) { /** Run commands to alter indexes * @param string escaped table name - * @param array of array("index type", "(columns definition)") or array("index type", "escaped name", "DROP") + * @param array of array("index type", "name", "(columns definition)") or array("index type", "name", "DROP") * @return bool */ function alter_indexes($table, $alter) { foreach ($alter as $key => $val) { - $alter[$key] = ($val[2] ? "\nDROP INDEX " : "\nADD $val[0] " . ($val[0] == "PRIMARY" ? "KEY " : "")) . $val[1]; + $alter[$key] = ($val[2] == "DROP" + ? "\nDROP INDEX " . idf_escape($val[1]) + : "\nADD $val[0] " . ($val[0] == "PRIMARY" ? "KEY " : "") . ($val[1] != "" ? idf_escape($val[1]) . " " : "") . $val[2] + ); } return queries("ALTER TABLE " . table($table) . implode(",", $alter)); } diff --git a/adminer/drivers/pgsql.inc.php b/adminer/drivers/pgsql.inc.php index 2c8767f2..821f258e 100644 --- a/adminer/drivers/pgsql.inc.php +++ b/adminer/drivers/pgsql.inc.php @@ -383,10 +383,13 @@ WHERE tc.constraint_type = 'FOREIGN KEY' AND tc.constraint_schema = current_sche $drop = array(); foreach ($alter as $val) { if ($val[0] != "INDEX") { - $create[] = ($val[2] ? "\nDROP CONSTRAINT " : "\nADD $val[0] " . ($val[0] == "PRIMARY" ? "KEY " : "")) . $val[1]; - } elseif ($val[2]) { - $drop[] = $val[1]; - } elseif (!queries("CREATE INDEX " . idf_escape(uniqid($table . "_")) . " ON " . table($table) . " $val[1]")) { + $create[] = ($val[2] == "DROP" + ? "\nDROP CONSTRAINT " . idf_escape($val[1]) + : "\nADD $val[0] " . ($val[0] == "PRIMARY" ? "KEY " : "") . $val[2] + ); + } elseif ($val[2] == "DROP") { + $drop[] = idf_escape($val[1]); + } elseif (!queries("CREATE INDEX " . idf_escape($val[1] != "" ? $val[1] : uniqid($table . "_")) . " ON " . table($table) . " $val[2]")) { return false; } } diff --git a/adminer/drivers/sqlite.inc.php b/adminer/drivers/sqlite.inc.php index f2883f5d..c7213e48 100644 --- a/adminer/drivers/sqlite.inc.php +++ b/adminer/drivers/sqlite.inc.php @@ -422,7 +422,10 @@ if (isset($_GET["sqlite"]) || isset($_GET["sqlite2"])) { function alter_indexes($table, $alter) { foreach ($alter as $val) { - if (!queries(($val[2] ? "DROP INDEX" : "CREATE" . ($val[0] != "INDEX" ? " UNIQUE" : "") . " INDEX " . idf_escape(uniqid($table . "_")) . " ON " . table($table)) . " $val[1]")) { + if (!queries($val[2] == "DROP" + ? "DROP INDEX " . idf_escape($val[1]) + : "CREATE $val[0] " . ($val[0] != "INDEX" ? "INDEX " : "") . idf_escape($val[1] != "" ? $val[1] : uniqid($table . "_")) . " ON " . table($table) . " $val[2]" + )) { return false; } } diff --git a/adminer/indexes.inc.php b/adminer/indexes.inc.php index 13b54fdd..7eb4874d 100644 --- a/adminer/indexes.inc.php +++ b/adminer/indexes.inc.php @@ -13,6 +13,7 @@ if ($jush == "sqlite") { // doesn't support primary key if ($_POST && !$error && !$_POST["add"]) { $alter = array(); foreach ($_POST["indexes"] as $index) { + $name = $index["name"]; if (in_array($index["type"], $index_types)) { $columns = array(); $lengths = array(); @@ -27,22 +28,23 @@ if ($_POST && !$error && !$_POST["add"]) { } } if ($columns) { - foreach ($indexes as $name => $existing) { + $existing = $indexes[$name]; + if ($existing) { ksort($existing["columns"]); ksort($existing["lengths"]); if ($index["type"] == $existing["type"] && array_values($existing["columns"]) === $columns && (!$existing["lengths"] || array_values($existing["lengths"]) === $lengths)) { // skip existing index unset($indexes[$name]); - continue 2; + continue; } } - $alter[] = array($index["type"], "(" . implode(", ", $set) . ")"); + $alter[] = array($index["type"], $name, "(" . implode(", ", $set) . ")"); } } } // drop removed indexes foreach ($indexes as $name => $existing) { - $alter[] = array($existing["type"], idf_escape($name), "DROP"); + $alter[] = array($existing["type"], $name, "DROP"); } if (!$alter) { redirect(ME . "table=" . urlencode($TABLE)); @@ -69,6 +71,7 @@ if ($_POST) { } } else { foreach ($row["indexes"] as $key => $index) { + $row["indexes"][$key]["name"] = $key; $row["indexes"][$key]["columns"][] = ""; } $row["indexes"][] = array("columns" => array(1 => "")); @@ -77,7 +80,7 @@ if ($_POST) {