From 7291ae608dd3f61c6c22423aa8a86715b6afa2f9 Mon Sep 17 00:00:00 2001 From: Jakub Vrana Date: Sun, 15 Jul 2012 09:21:22 -0700 Subject: [PATCH] Reset error before using in SQL query --- adminer/drivers/mssql.inc.php | 3 +++ adminer/drivers/mysql.inc.php | 1 + adminer/drivers/oracle.inc.php | 1 + adminer/drivers/pgsql.inc.php | 1 + adminer/drivers/sqlite.inc.php | 2 ++ adminer/include/pdo.inc.php | 1 + 6 files changed, 9 insertions(+) diff --git a/adminer/drivers/mssql.inc.php b/adminer/drivers/mssql.inc.php index 8463885a..9f9c481e 100644 --- a/adminer/drivers/mssql.inc.php +++ b/adminer/drivers/mssql.inc.php @@ -43,6 +43,7 @@ if (isset($_GET["mssql"])) { function query($query, $unbuffered = false) { $result = sqlsrv_query($this->_link, $query); //! , array(), ($unbuffered ? array() : array("Scrollable" => "keyset")) + $this->error = ""; if (!$result) { $this->_get_error(); return false; @@ -52,6 +53,7 @@ if (isset($_GET["mssql"])) { function multi_query($query) { $this->_result = sqlsrv_query($this->_link, $query); + $this->error = ""; if (!$this->_result) { $this->_get_error(); return false; @@ -159,6 +161,7 @@ if (isset($_GET["mssql"])) { function query($query, $unbuffered = false) { $result = mssql_query($query, $this->_link); //! $unbuffered + $this->error = ""; if (!$result) { $this->error = mssql_get_last_message(); return false; diff --git a/adminer/drivers/mysql.inc.php b/adminer/drivers/mysql.inc.php index d7ed85db..72b65221 100644 --- a/adminer/drivers/mysql.inc.php +++ b/adminer/drivers/mysql.inc.php @@ -108,6 +108,7 @@ if (!defined("DRIVER")) { */ function query($query, $unbuffered = false) { $result = @($unbuffered ? mysql_unbuffered_query($query, $this->_link) : mysql_query($query, $this->_link)); // @ - mute mysql.trace_mode + $this->error = ""; if (!$result) { $this->error = mysql_error($this->_link); return false; diff --git a/adminer/drivers/oracle.inc.php b/adminer/drivers/oracle.inc.php index 48163b16..65662bfe 100644 --- a/adminer/drivers/oracle.inc.php +++ b/adminer/drivers/oracle.inc.php @@ -37,6 +37,7 @@ if (isset($_GET["oracle"])) { function query($query, $unbuffered = false) { $result = oci_parse($this->_link, $query); + $this->error = ""; if (!$result) { $error = oci_error($this->_link); $this->error = $error["message"]; diff --git a/adminer/drivers/pgsql.inc.php b/adminer/drivers/pgsql.inc.php index 8f98460f..49db9a36 100644 --- a/adminer/drivers/pgsql.inc.php +++ b/adminer/drivers/pgsql.inc.php @@ -58,6 +58,7 @@ if (isset($_GET["pgsql"])) { function query($query, $unbuffered = false) { $result = @pg_query($this->_link, $query); + $this->error = ""; if (!$result) { $this->error = pg_last_error($this->_link); return false; diff --git a/adminer/drivers/sqlite.inc.php b/adminer/drivers/sqlite.inc.php index 3ad2fc73..3233613a 100644 --- a/adminer/drivers/sqlite.inc.php +++ b/adminer/drivers/sqlite.inc.php @@ -19,6 +19,7 @@ if (isset($_GET["sqlite"]) || isset($_GET["sqlite2"])) { function query($query) { $result = @$this->_link->query($query); + $this->error = ""; if (!$result) { $this->error = $this->_link->lastErrorMsg(); return false; @@ -93,6 +94,7 @@ if (isset($_GET["sqlite"]) || isset($_GET["sqlite2"])) { function query($query, $unbuffered = false) { $method = ($unbuffered ? "unbufferedQuery" : "query"); $result = @$this->_link->$method($query, SQLITE_BOTH, $error); + $this->error = ""; if (!$result) { $this->error = $error; return false; diff --git a/adminer/include/pdo.inc.php b/adminer/include/pdo.inc.php index a77265a6..b72d68f9 100644 --- a/adminer/include/pdo.inc.php +++ b/adminer/include/pdo.inc.php @@ -24,6 +24,7 @@ if (extension_loaded('pdo')) { function query($query, $unbuffered = false) { $result = parent::query($query); + $this->error = ""; if (!$result) { $errorInfo = $this->errorInfo(); $this->error = $errorInfo[2];