From 51abdcdab9b72231b20341adec54b4ee1d044635 Mon Sep 17 00:00:00 2001
From: Jakub Vrana <jakub@vrana.cz>
Date: Mon, 8 Feb 2021 19:56:15 +0100
Subject: [PATCH] SimpleDB, Firebird, ClickHouse: Move to plugin

---
 adminer/include/bootstrap.inc.php               |  5 +----
 adminer/include/driver.inc.php                  | 11 +++++++++++
 adminer/include/pdo.inc.php                     |  2 --
 adminer/plugin.php                              |  3 +++
 changes.txt                                     |  1 +
 compile.php                                     |  5 ++++-
 plugins/drivers/README                          | 11 +++++++++++
 {adminer => plugins}/drivers/clickhouse.inc.php |  2 +-
 {adminer => plugins}/drivers/firebird.inc.php   |  4 ++--
 {adminer => plugins}/drivers/simpledb.inc.php   |  2 +-
 10 files changed, 35 insertions(+), 11 deletions(-)
 create mode 100644 plugins/drivers/README
 rename {adminer => plugins}/drivers/clickhouse.inc.php (99%)
 rename {adminer => plugins}/drivers/firebird.inc.php (99%)
 rename {adminer => plugins}/drivers/simpledb.inc.php (99%)

diff --git a/adminer/include/bootstrap.inc.php b/adminer/include/bootstrap.inc.php
index 114b4ca4..9349d42c 100644
--- a/adminer/include/bootstrap.inc.php
+++ b/adminer/include/bootstrap.inc.php
@@ -80,11 +80,9 @@ include "../adminer/drivers/sqlite.inc.php";
 include "../adminer/drivers/pgsql.inc.php";
 include "../adminer/drivers/oracle.inc.php";
 include "../adminer/drivers/mssql.inc.php";
-include "../adminer/drivers/firebird.inc.php";
-include "../adminer/drivers/simpledb.inc.php";
 include "../adminer/drivers/mongo.inc.php";
 include "../adminer/drivers/elastic.inc.php";
-include "../adminer/drivers/clickhouse.inc.php";
+include "./include/adminer.inc.php";
 include "../adminer/drivers/mysql.inc.php"; // must be included as last driver
 
 $config = driver_config();
@@ -108,7 +106,6 @@ define("ME", preg_replace('~\?.*~', '', relative_uri()) . '?'
 );
 
 include "../adminer/include/version.inc.php";
-include "./include/adminer.inc.php";
 include "../adminer/include/design.inc.php";
 include "../adminer/include/xxtea.inc.php";
 include "../adminer/include/auth.inc.php";
diff --git a/adminer/include/driver.inc.php b/adminer/include/driver.inc.php
index 893d1667..99582bd4 100644
--- a/adminer/include/driver.inc.php
+++ b/adminer/include/driver.inc.php
@@ -1,4 +1,15 @@
 <?php
+$drivers = array();
+
+/** Add a driver
+* @param string
+* @param string
+* @return null
+*/
+function add_driver($id, $name) {
+	global $drivers;
+	$drivers[$id] = $name;
+}
 
 /*abstract*/ class Min_SQL {
 	var $_conn;
diff --git a/adminer/include/pdo.inc.php b/adminer/include/pdo.inc.php
index ed7ac497..b0f8b62b 100644
--- a/adminer/include/pdo.inc.php
+++ b/adminer/include/pdo.inc.php
@@ -100,5 +100,3 @@ if (extension_loaded('pdo')) {
 		}
 	}
 }
-
-$drivers = array();
diff --git a/adminer/plugin.php b/adminer/plugin.php
index 3fb1b549..31071fce 100644
--- a/adminer/plugin.php
+++ b/adminer/plugin.php
@@ -8,6 +8,9 @@ function adminer_object() {
 		include_once $filename;
 	}
 	
+	// enable extra drivers just by including them
+	//~ include "../plugins/drivers/simpledb.inc.php";
+	
 	$plugins = array(
 		// specify enabled plugins here
 		new AdminerDatabaseHide(array('information_schema')),
diff --git a/changes.txt b/changes.txt
index 830f7e88..a5fdebaa 100644
--- a/changes.txt
+++ b/changes.txt
@@ -9,6 +9,7 @@ PostgreSQL: Create PRIMARY KEY for auto increment columns
 PostgreSQL: Avoid exporting empty sequence last value (bug #768)
 PostgreSQL: Fix multi-parameter functions in default values (bug #736)
 PostgreSQL PDO: Do not select NULL function for false values in edit
+SimpleDB, Firebird, ClickHouse: Move to plugin
 
 Adminer 4.7.9 (released 2021-02-07):
 Fix XSS in browsers which don't encode URL parameters (bug #775, regression from 4.7.0)
diff --git a/compile.php b/compile.php
index 574fe6ef..eb685253 100755
--- a/compile.php
+++ b/compile.php
@@ -41,7 +41,7 @@ function lang_ids($match) {
 }
 
 function put_file($match) {
-	global $project, $VERSION;
+	global $project, $VERSION, $driver;
 	if (basename($match[2]) == '$LANG.inc.php') {
 		return $match[0]; // processed later
 	}
@@ -61,6 +61,9 @@ header("Cache-Control: immutable");
 			echo "adminer/file.inc.php: Caching headers placeholder not found\n";
 		}
 	}
+	if ($driver && dirname($match[2]) == "../adminer/drivers") {
+		$return = preg_replace('~^if \(isset\(\$_GET\["' . $driver . '"]\)\) \{(.*)^}~ms', '\1', $return);
+	}
 	if (basename($match[2]) != "lang.inc.php" || !$_SESSION["lang"]) {
 		if (basename($match[2]) == "lang.inc.php") {
 			$return = str_replace('function lang($idf, $number = null) {', 'function lang($idf, $number = null) {
diff --git a/plugins/drivers/README b/plugins/drivers/README
new file mode 100644
index 00000000..ee3ac886
--- /dev/null
+++ b/plugins/drivers/README
@@ -0,0 +1,11 @@
+Enable drivers in this directory like this:
+
+<?php
+function adminer_object() {
+	include "./plugins/drivers/simpledb.inc.php"; // the driver is enabled just by including
+	return new Adminer; // or return AdminerPlugin if you want to use other plugins
+}
+
+// include original Adminer
+include "./adminer.php";
+?>
diff --git a/adminer/drivers/clickhouse.inc.php b/plugins/drivers/clickhouse.inc.php
similarity index 99%
rename from adminer/drivers/clickhouse.inc.php
rename to plugins/drivers/clickhouse.inc.php
index ec5db517..60bb0b45 100644
--- a/adminer/drivers/clickhouse.inc.php
+++ b/plugins/drivers/clickhouse.inc.php
@@ -1,5 +1,5 @@
 <?php
-$drivers["clickhouse"] = "ClickHouse (alpha)";
+add_driver("clickhouse", "ClickHouse (alpha)");
 
 if (isset($_GET["clickhouse"])) {
 	define("DRIVER", "clickhouse");
diff --git a/adminer/drivers/firebird.inc.php b/plugins/drivers/firebird.inc.php
similarity index 99%
rename from adminer/drivers/firebird.inc.php
rename to plugins/drivers/firebird.inc.php
index 7e62930c..fc46f3a7 100644
--- a/adminer/drivers/firebird.inc.php
+++ b/plugins/drivers/firebird.inc.php
@@ -3,8 +3,8 @@
 * @author Steve Krämer
 */
 
-$drivers['firebird'] = 'Firebird (alpha)';
-	
+add_driver('firebird', 'Firebird (alpha)');
+
 if (isset($_GET["firebird"])) {
 	define("DRIVER", "firebird");
 
diff --git a/adminer/drivers/simpledb.inc.php b/plugins/drivers/simpledb.inc.php
similarity index 99%
rename from adminer/drivers/simpledb.inc.php
rename to plugins/drivers/simpledb.inc.php
index 4dce229d..9fafe884 100644
--- a/adminer/drivers/simpledb.inc.php
+++ b/plugins/drivers/simpledb.inc.php
@@ -1,5 +1,5 @@
 <?php
-$drivers["simpledb"] = "SimpleDB";
+add_driver("simpledb", "SimpleDB");
 
 if (isset($_GET["simpledb"])) {
 	define("DRIVER", "simpledb");