beenull/XBackBone
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Added logging

Browse source
This commit is contained in:
Sergio Brighenti 2021-03-07 17:37:20 +01:00
parent b72e9cda30
commit f6df098915
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
CHANGELOG.md
View file

@ -4,11 +4,16 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
## [3.3.4] - 2021-03-07 ## [3.3.4] - 2021-03-07
### Added
- Login failed logging.
- User identifier option for LDAP configurations.
### Fixed ### Fixed
- Fixed open graph meta tags for Discord. - Fixed open graph meta tags for Discord.
- Fixed custom html tags are not displayed back in the admin setting. - Fixed custom html tags are not displayed back in the admin setting.
- Fixed python plugin for newer version of Screencloud. - Fixed python plugin for newer version of Screencloud.
- Fixed accented chars in email subject. - Fixed accented chars in email subject.
- Fixed error on PHP 8.
## [3.3.3] - 2020-11-13 ## [3.3.3] - 2020-11-13
### Fixed ### Fixed

4
app/Controllers/Auth/LoginController.php
View file

@ -48,6 +48,7 @@ class LoginController extends AuthController
} }
$username = param($request, 'username'); $username = param($request, 'username');
$password = param($request, 'password');
$user = $this->database->query('SELECT `id`, `email`, `username`, `password`,`is_admin`, `active`, `current_disk_quota`, `max_disk_quota`, `ldap`, `copy_raw` FROM `users` WHERE `username` = ? OR `email` = ? LIMIT 1', [$username, $username])->fetch(); $user = $this->database->query('SELECT `id`, `email`, `username`, `password`,`is_admin`, `active`, `current_disk_quota`, `max_disk_quota`, `ldap`, `copy_raw` FROM `users` WHERE `username` = ? OR `email` = ? LIMIT 1', [$username, $username])->fetch();
if ($this->config['ldap']['enabled'] && ($user->ldap ?? true)) { if ($this->config['ldap']['enabled'] && ($user->ldap ?? true)) {
@ -55,11 +56,12 @@ class LoginController extends AuthController
} }
$validator $validator
->alertIf(!$user || !password_verify(param($request, 'password'), $user->password), 'bad_login') ->alertIf(!$user || !password_verify($password, $user->password), 'bad_login')
->alertIf(isset($this->config['maintenance']) && $this->config['maintenance'] && !($user->is_admin ?? true), 'maintenance_in_progress', 'info') ->alertIf(isset($this->config['maintenance']) && $this->config['maintenance'] && !($user->is_admin ?? true), 'maintenance_in_progress', 'info')
->alertIf(!($user->active ?? false), 'account_disabled'); ->alertIf(!($user->active ?? false), 'account_disabled');
if ($validator->fails()) { if ($validator->fails()) {
$this->logger->info("Login failed with username='{$username}', password='{$password}'.");
return redirect($response, route('login')); return redirect($response, route('login'));
} }