beenull/SparkleShare
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

SparkleListenerBase: Fixing delivering of queued messages.

Browse source 
Removing a list item from inside a foreach causes a "InvalidOperationException: Collection Was Modified" error. First creating a copy fixes this.
This commit is contained in:
PierreAronnax 2011-10-25 20:16:20 +02:00
parent 5c68b3242b
commit 7c958c98bd
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
SparkleLib/SparkleListenerBase.cs
View file

@ -148,7 +148,7 @@ namespace SparkleLib {
public bool HasQueueDownAnnouncement (string folder_identifier)
{
foreach (SparkleAnnouncement announcement in this.queue_down) {
foreach (SparkleAnnouncement announcement in this.queue_down.GetRange(0, this.queue_down.Count)) {
if (announcement.FolderIdentifier.Equals (folder_identifier)) {
this.queue_down.Remove (announcement);
return true;
@ -174,9 +174,9 @@ namespace SparkleLib {
Connected ();
if (this.queue_up.Count > 0) {
SparkleHelpers.DebugInfo ("Listener", "Delivering queued messages...");
SparkleHelpers.DebugInfo ("Listener", "Delivering " + this.queue_up.Count + " queued messages...");
foreach (SparkleAnnouncement announcement in this.queue_up) {
foreach (SparkleAnnouncement announcement in this.queue_up.GetRange(0, this.queue_up.Count)) {
AnnounceBase (announcement);
this.queue_up.Remove (announcement);
}