From 714a55b32a0bf23ff86221a662ddf85ef8180333 Mon Sep 17 00:00:00 2001 From: Hylke Bons Date: Sat, 12 Mar 2011 16:18:36 +0000 Subject: [PATCH] [fetcher] no need to keep error message in memory --- SparkleLib/SparkleFetcher.cs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/SparkleLib/SparkleFetcher.cs b/SparkleLib/SparkleFetcher.cs index 5cbbb999..0e5c5fd5 100644 --- a/SparkleLib/SparkleFetcher.cs +++ b/SparkleLib/SparkleFetcher.cs @@ -37,7 +37,6 @@ namespace SparkleLib { private string TargetFolder; private string RemoteOriginUrl; - private string Command_Error; public SparkleFetcher (string url, string folder) { @@ -79,8 +78,10 @@ namespace SparkleLib { SparkleHelpers.DebugInfo ("Git", "Exit code " + process.ExitCode.ToString ()); if (process.ExitCode != 0) { + + string error = process.StandardError.ReadToEnd (); - SparkleHelpers.DebugInfo ("Git", "Error: " + Command_Error); + SparkleHelpers.DebugInfo ("Git", "Error: " + error); SparkleHelpers.DebugInfo ("Git", "[" + TargetFolder + "] Cloning failed"); if (CloningFailed != null) @@ -101,8 +102,8 @@ namespace SparkleLib { }; process.Start (); - Command_Error = process.StandardError.ReadToEnd (); process.WaitForExit (); + }