From a4c1b0e464e0679a1ef46e44ced60d744a693434 Mon Sep 17 00:00:00 2001
From: tteckster <tteckster@gmail.com>
Date: Sun, 5 Feb 2023 12:36:42 -0500
Subject: [PATCH] Update clean-lxcs.sh

code optimization
---
 misc/clean-lxcs.sh | 17 ++++-------------
 1 file changed, 4 insertions(+), 13 deletions(-)

diff --git a/misc/clean-lxcs.sh b/misc/clean-lxcs.sh
index 4bda3c1a..8c35219a 100644
--- a/misc/clean-lxcs.sh
+++ b/misc/clean-lxcs.sh
@@ -1,6 +1,7 @@
 #!/bin/bash
 function header_info {
-  cat <<"EOF"
+clear
+cat <<"EOF"
    ________                    __   _  ________
   / ____/ /__  ____ _____     / /  | |/ / ____/
  / /   / / _ \/ __ `/ __ \   / /   |   / /     
@@ -16,7 +17,6 @@ RD=$(echo "\033[01;31m")
 CM='\xE2\x9C\x94\033'
 GN=$(echo "\033[1;92m")
 CL=$(echo "\033[m")
-clear
 header_info
 echo -e "\n ${RD} USE AT YOUR OWN RISK. Deleting logs/cache may result in some apps/services broken!${CL} \n"
 while true; do
@@ -31,9 +31,8 @@ clear
 containers=$(pct list | tail -n +2 | cut -f1 -d' ')
 function clean_container() {
   container=$1
-  clear
   header_info
-  name=`pct exec $container hostname`
+  name=$(pct exec "$container" hostname)
   echo -e "${BL}[Info]${GN} Cleaning ${name} ${CL} \n"
   pct exec $container -- bash -c "apt-get -y --purge autoremove && apt-get -y autoclean && bash <(curl -fsSL https://github.com/tteck/Proxmox/raw/main/misc/clean.sh) && rm -rf /var/lib/apt/lists/* && apt-get update"
 }
@@ -47,8 +46,7 @@ fi
 
 for container in $containers; do
   status=$(pct status $container)
-  if [ "$skip" == "no" ]; then
-    if [ "$status" == "status: stopped" ]; then
+  if [ "$skip" == "no" ] && [ "$status" == "status: stopped" ]; then
       echo -e "${BL}[Info]${GN} Starting${BL} $container ${CL} \n"
       pct start $container
       echo -e "${BL}[Info]${GN} Waiting For${BL} $container${CL}${GN} To Start ${CL} \n"
@@ -58,15 +56,8 @@ for container in $containers; do
       pct shutdown $container &
     elif [ "$status" == "status: running" ]; then
       clean_container $container
-    fi
-  fi
-  if [ "$skip" == "yes" ]; then
-    if [ "$status" == "status: running" ]; then
-      clean_container $container
-    fi
   fi
 done
 wait
-clear
 header_info
 echo -e "${GN} Finished, Containers Cleaned. ${CL} \n"